Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust): Fix Display implementation of Duration #15647

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

MarcoGorelli
Copy link
Collaborator

@MarcoGorelli MarcoGorelli commented Apr 14, 2024

It's currently off by a factor of 1_000, '20h' gets displayed as '72000000h' instead of '72000h'

Pulling some constants together and using those instead

I may well have some typos here, but I'm just going out - will fixup when I get back

@github-actions github-actions bot added fix Bug fix rust Related to Rust Polars labels Apr 14, 2024
@MarcoGorelli MarcoGorelli force-pushed the refactors branch 2 times, most recently from efd22b8 to 9845fe2 Compare April 14, 2024 13:10
Copy link

codspeed-hq bot commented Apr 14, 2024

CodSpeed Performance Report

Merging #15647 will not alter performance

Comparing MarcoGorelli:refactors (d103644) with main (37c6303)

Summary

✅ 22 untouched benchmarks

Copy link

codecov bot commented Apr 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.31%. Comparing base (81002ca) to head (d103644).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15647   +/-   ##
=======================================
  Coverage   81.30%   81.31%           
=======================================
  Files        1373     1373           
  Lines      176243   176254   +11     
  Branches     2544     2544           
=======================================
+ Hits       143302   143321   +19     
+ Misses      32458    32452    -6     
+ Partials      483      481    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcoGorelli MarcoGorelli marked this pull request as ready for review April 14, 2024 21:55
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@stinodego stinodego changed the title fix(rust): fix display of Duration fix(rust): Fix Display implementation for of Duration Apr 15, 2024
@stinodego stinodego changed the title fix(rust): Fix Display implementation for of Duration fix(rust): Fix Display implementation for Duration Apr 15, 2024
@stinodego stinodego changed the title fix(rust): Fix Display implementation for Duration fix(rust): Fix Display implementation of Duration Apr 15, 2024
@stinodego stinodego merged commit 99ab9c0 into pola-rs:main Apr 15, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants