-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rust): Fix Display implementation of Duration #15647
Conversation
efd22b8
to
9845fe2
Compare
CodSpeed Performance ReportMerging #15647 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15647 +/- ##
=======================================
Coverage 81.30% 81.31%
=======================================
Files 1373 1373
Lines 176243 176254 +11
Branches 2544 2544
=======================================
+ Hits 143302 143321 +19
+ Misses 32458 32452 -6
+ Partials 483 481 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
It's currently off by a factor of 1_000,
'20h'
gets displayed as'72000000h'
instead of'72000h'
Pulling some constants together and using those insteadI may well have some typos here, but I'm just going out - will fixup when I get back