chore: make Duration.is_constant_duration less strict for non-timezone-aware case #15639
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
splitting this off from #15638
There's currently a method
Duration.is_constant_duration
, which returnsfalse
if the duration contains calendar durations (months, weeks, days).However, for the time-zone-naive case (and the UTC case), days and weeks are constant durations too, as they're not affected by daylight saving time
There's no implication for the current tests (but it will help with #15638, as there
half_life
has to be a constant duration)