Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Use vertical parallelism if input is chunked for Filter,Select,WithColumns #15608

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented Apr 12, 2024

Readers often get chunked data. Now we decide to not rechunk on default. If we have elementwise operations we can now create tasks vertically (over chunks) and horizontally (over columns). This should saturate your thread much more if you do elementwise operations.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Apr 12, 2024
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 99.36709% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.15%. Comparing base (5e74924) to head (bc04c8d).
Report is 4 commits behind head on main.

❗ Current head bc04c8d differs from pull request most recent head 065661a. Consider uploading reports for the commit 065661a to get more accurate results

Files Patch % Lines
crates/polars-plan/src/logical_plan/aexpr/utils.rs 96.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15608      +/-   ##
==========================================
- Coverage   81.16%   81.15%   -0.02%     
==========================================
  Files        1367     1371       +4     
  Lines      174992   175770     +778     
  Branches     2530     2531       +1     
==========================================
+ Hits       142031   142644     +613     
- Misses      32484    32648     +164     
- Partials      477      478       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Apr 12, 2024

CodSpeed Performance Report

Merging #15608 will not alter performance

Comparing vert (065661a) with main (0b84b14)

Summary

✅ 22 untouched benchmarks

@ritchie46 ritchie46 merged commit 6d7ddcc into main Apr 12, 2024
24 checks passed
@ritchie46 ritchie46 deleted the vert branch April 12, 2024 12:18
@c-peters c-peters added the accepted Ready for implementation label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants