-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix elementwise-apply if any input is AggregatedScalar
#15606
Conversation
if acs.iter().any(|ac| { | ||
matches!( | ||
ac.agg_state(), | ||
AggState::AggregatedList(_) | AggState::AggregatedScalar(_) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC, AggregatedScalar
has the size equals to group len
, It cannot do the fully element-wise apply. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it can if all ac
s are AggregatedScalar
. I think any NotAggregated
cannot combine with AggregatedList | AggregatedScalar
(eg aggregated
).
So if all are AggregatedScalar
and the groups are equal we could still go int he elementwise, I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So if all are AggregatedScalar and the groups are equal we could still go int he elementwise, I think
Yes, you're right. I just think this All AggregatedScalar
condition could be relaxed, AggregatedScalar
and Literal
can also go to the element-wise branch, right?
CodSpeed Performance ReportMerging #15606 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15606 +/- ##
==========================================
+ Coverage 81.16% 81.19% +0.02%
==========================================
Files 1367 1370 +3
Lines 175307 175639 +332
Branches 2527 2530 +3
==========================================
+ Hits 142296 142606 +310
- Misses 32534 32559 +25
+ Partials 477 474 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeap, good one!
This fixes #15602.