Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change default to write parquet statistics #15597

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

deanm0000
Copy link
Collaborator

addresses #15586

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Apr 11, 2024
Copy link

codspeed-hq bot commented Apr 11, 2024

CodSpeed Performance Report

Merging #15597 will not alter performance

Comparing deanm0000:write_stats_by_default (9df2ca1) with main (c8e26ca)

Summary

✅ 22 untouched benchmarks

@deanm0000
Copy link
Collaborator Author

deanm0000 commented Apr 11, 2024

@ritchie46 here is the default to writing statistics PR. Hopefully there's just the one place on the rust side.

@stinodego
Copy link
Member

This would be breaking. We should probably deprecate the previous behavior first, or if we deem this to be very small impact, we can just break it with 1.0.0.

@stinodego stinodego changed the title feat: change default to write parquet statistics feat!: change default to write parquet statistics Apr 11, 2024
@github-actions github-actions bot added the breaking Change that breaks backwards compatibility label Apr 11, 2024
@ritchie46
Copy link
Member

ritchie46 commented Apr 12, 2024

Good consideration @stinodego , but I don't think this is breaking. It adds extra statistic to the file. But we are free to change encodings how we please normally to the parquet format as well. Your queries would still work as is. I think our semver limits to our API not our output formats.

I've seen this happening in pyarow's output as well. So I don't think this is very strange.

Thanks you @deanm0000. I will merge this, because of the above reasons. :)

@ritchie46 ritchie46 changed the title feat!: change default to write parquet statistics feat: change default to write parquet statistics Apr 12, 2024
@ritchie46 ritchie46 removed the breaking Change that breaks backwards compatibility label Apr 12, 2024
@ritchie46 ritchie46 merged commit 0a594af into pola-rs:main Apr 12, 2024
28 checks passed
@deanm0000 deanm0000 deleted the write_stats_by_default branch August 26, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants