fix(python): No longer error when schema_overrides contains nonexistent columns
#15528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15528 +/- ##
==========================================
- Coverage 81.16% 81.15% -0.01%
==========================================
Files 1362 1362
Lines 175001 174999 -2
Branches 2532 2532
==========================================
- Hits 142037 142026 -11
- Misses 32481 32491 +10
+ Partials 483 482 -1 ☔ View full report in Codecov by Sentry. |
stinodego
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
|
@stinodego thank you very much for the quick response, the flexibility, the analysis and the final change |
ritchie46
reviewed
Apr 8, 2024
| @@ -123,9 +124,16 @@ def test_df_init_from_series_strict() -> None: | |||
| assert df["a"].dtype == pl.UInt8 | |||
|
|
|||
|
|
|||
| # https://github.com/pola-rs/polars/issues/15471 | |||
There was a problem hiding this comment.
Suggested change
| # https://github.com/pola-rs/polars/issues/15471 |
ritchie46
reviewed
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts the change in #15290
Closes #15471
As per the discussion in the linked issue, being able to pass nonexistent columns in
schema_overridesis actually pretty useful in certain situations. I had not foreseen this, so I am reverting the check I introduced for this.