refactor(python): Remove private DataFrame._read classmethods
#15521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
stinodego
changed the title
DataFrame._read_* classmethodsDataFrame._read classmethods
stinodego
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15521 +/- ##
==========================================
+ Coverage 81.14% 81.16% +0.01%
==========================================
Files 1362 1362
Lines 174989 174999 +10
Branches 2533 2533
==========================================
+ Hits 142000 142033 +33
+ Misses 32505 32482 -23
Partials 484 484 ☔ View full report in Codecov by Sentry. |
stinodego
commented
Apr 7, 2024
| @@ -85,7 +85,7 @@ doctest: .venv build ## Run doctests | |||
| $(VENV_BIN)/pytest tests/docs/test_user_guide.py -m docs | |||
|
|
|||
| .PHONY: docs | |||
| docs: .venv build ## Build Python docs (incremental) | |||
There was a problem hiding this comment.
This was a drive-by: building the docs does not rely on the Polars binary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of IO functionality was (unnecessarily) split between two places. This centralizes the logic in 1 place, makes subsequent refactors easier. There is a LOT of duplication here.