fix(python): Raise if pass a negative n
into clear
#15432
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns the behavior of
series.clear(-1)
anddf.clear(-1)
.NB. Before this change, the error of
df.clear(-1)
is raised from theextend_constant
(pass a negative n), I think a more explicit error would be nice.The only difference is that for an empty series, passing a negative
n
does not throw an error before this change. I feel like it makes the function behave a bit more predictable if we rejectn < 0
outright, WDYT?This fixes #15421.