Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement Series/Expr.list.product #15148

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

petrosbar
Copy link
Contributor

@petrosbar petrosbar commented Mar 19, 2024

Another attempt for #12862.

Note: Optimised handling of null-free cases is intentionally not included in this PR, to keep it as small as possible. But it will be done in a separate, follow-up PR.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Mar 19, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.41%. Comparing base (d11da5e) to head (c65ffe4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15148      +/-   ##
==========================================
- Coverage   81.37%   80.41%   -0.97%     
==========================================
  Files        1379     1265     -114     
  Lines      176843   165498   -11345     
  Branches     2543        0    -2543     
==========================================
- Hits       143908   133084   -10824     
+ Misses      32452    32414      -38     
+ Partials      483        0     -483     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Apr 16, 2024

CodSpeed Performance Report

Merging #15148 will not alter performance

Comparing petrosbar:list-product-2 (c65ffe4) with main (d11da5e)

Summary

✅ 21 untouched benchmarks

@petrosbar
Copy link
Contributor Author

@ritchie46 @stinodego perhaps you could have a look at this one? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants