-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(python): Improve API reference landing page #14888
Conversation
css is alien to me but the result looks really nice, well done |
I like this in general, but I have a few suggestions (obviously my opinion, feel free to disagree!):
|
check https://docs.pola.rs/development/versioning/ (anything non-public wouldn't go through a deprecation cycle) |
I like the organization in boxes. The ordering in the menu is debatable but the new order is fair enough (I would keep DataFrame/Series together followed by LazyFrame/Expressions). I need a moment to consider the redirect, not 100% sure it's a good idea. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14888 +/- ##
=======================================
Coverage 81.00% 81.01%
=======================================
Files 1331 1331
Lines 172728 172774 +46
Branches 2455 2455
=======================================
+ Hits 139922 139973 +51
+ Misses 32339 32334 -5
Partials 467 467 ☔ View full report in Codecov by Sentry. |
It doesn't affect the docs indexing (the redirect is injected after the pages are generated from the |
Yup; not hard at all, but can be done in a second pass if somebody comes up with good titles. This is a meant as a decent first step that can be built/iterated on.
Definitely too much; this isn't about hiding things so much as better-organising useful information.
Done.
It is; if the links aren't going somewhere useful and you can work out how to tweak/redirect, let me know ;) |
Can't you transfer the content of Edit: I see, this is generated by Sphynx. |
f04feef
to
1343d31
Compare
1343d31
to
a5332bc
Compare
edd2695
to
cac54df
Compare
Can we merge this? Looks nice. :) |
@stinodego - final thoughts on the redirect? Doesn't have to be permanent if you can think of something better to do with that root page, but currently it just looks broken 😅 |
I wouldn't say it looks broken, but it definitely isn't really useful as we use Sphinx only for the API reference. The redirect is fine, but we have to make sure we point directly to the |
Meaningful improvements to the presentation of the Python API docs, focusing on the primary landing page. "A picture tells a thousand words", so screenshots attached ;)
(There's a lot more we can do here, but this already feels like a decent upgrade).
Before
A strangely ordered list, meandering down the page; little structure or organisation. Not clear where each section begins/ends, as everything runs into everything else.
Ugly vertical scrollbar appearing in the left navbar.
After
Grid/card layout featuring the same elements, but the most important classes now appear in something resembling priority order (DataFrame → LazyFrame → Series → Expressions→ ...)
Minor custom CSS directive takes care of the ugly vertical scrollbar.
Update: have also now sorted the IO section for better readability.
Also