chore(python): Bump ruff version to 0.2.0 #14294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
stinodego
changed the title
stinodego
requested review from
ritchie46,
c-peters,
alexander-beedie and
MarcoGorelli
as code owners
mcrumiller
reviewed
Feb 6, 2024
|
|
||
| [tool.ruff.pycodestyle] | ||
| [tool.ruff.lint.pycodestyle] | ||
| max-doc-length = 88 |
There was a problem hiding this comment.
Unrelated to this PR, but what are your thoughts on bumping the max-doc-length up to, say, 120? A lot of the doc examples go past 88 and there are a lot of # noqa: W505's in there. I get keeping code short to maintain readability, but for docs I think a short doc width actually can hurt.
There was a problem hiding this comment.
Definitely not. There are a few exceptions but not many. The short summary should be short - for the rest, you have as many lines as you need.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing exciting happening this version bump, but I went ahead with it to future-proof the config files.