chore(rust): Rename lazy-regex feature to regex to align polars with polars-lazy crate
#13647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
stinodego
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
orlp
as code owners
stinodego
changed the title
lazy-regex feature to regex to match polars-lazy cratelazy-regex feature to regex to align polars with polars-lazy crate
|
Yes, originally there was a difference with the feature for column expansion and |
r-brink
pushed a commit
to r-brink/polars
that referenced
this pull request
Jan 24, 2024
… with `polars-lazy` crate (pola-rs#13647)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11178
Supersedes #11897
The feature is named
regexin thepolars-lazycrate, but it is namedlazy_regexin the mainpolarscrate. This can understandably lead to confusion when users read the lazy docs and see a feature is available under "regex", yet that feature is not available on the main crate.This aligns the feature names under
regex, which I feel is fine (no need for the lazy prefix).