Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Improve documentation on broadcasting #13394

Merged
merged 4 commits into from
Jan 10, 2024
Merged

docs: Improve documentation on broadcasting #13394

merged 4 commits into from
Jan 10, 2024

Conversation

Wainberg
Copy link
Contributor

@Wainberg Wainberg commented Jan 2, 2024

Closes #12651.

@Wainberg Wainberg changed the title Add documentation on broadcasting docs(python): add documentation on broadcasting Jan 2, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars labels Jan 2, 2024
@Wainberg
Copy link
Contributor Author

Wainberg commented Jan 7, 2024

@stinodego is this the kind of thing you had in mind?

@stinodego stinodego changed the title docs(python): add documentation on broadcasting docs: Improve documentation on broadcasting Jan 10, 2024
@github-actions github-actions bot added the rust Related to Rust Polars label Jan 10, 2024
stinodego
stinodego approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@stinodego stinodego left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some updates as some of the notes were not entirely accurate.

Mostly there is just one selection context, but multiple ways to enter it.

Overall though, the text now reads better 👍 thanks!

@stinodego stinodego merged commit 4b4eecc into pola-rs:main Jan 10, 2024
5 checks passed
@Wainberg Wainberg deleted the broadcasting-documentation branch January 10, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego stinodego approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@orlp orlp Awaiting requested review from orlp

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add documentation on broadcasting
2 participants
@Wainberg @stinodego