Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(python): Future-proof consortium standard test #12524

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

MarcoGorelli
Copy link
Collaborator

@MarcoGorelli MarcoGorelli commented Nov 16, 2023

It's quite likely that the dataframe api will have a Scalar class, and that Column.get_value will return that

I'm suggesting to just simplify the test to make an assertion about Column.name, which realistically isn't going to change


corresponding pandas PR: pandas-dev/pandas#55993

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Nov 16, 2023
@MarcoGorelli MarcoGorelli marked this pull request as ready for review November 16, 2023 17:39
@stinodego stinodego changed the title chore(python): future-proof consortium standard test chore(python): Future-proof consortium standard test Nov 16, 2023
@stinodego stinodego changed the title chore(python): Future-proof consortium standard test test(python): Future-proof consortium standard test Nov 16, 2023
@stinodego stinodego merged commit 536f334 into pola-rs:main Nov 16, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants