feat: remove lexical (replace with atoi_simd, ryu, and itao). #12512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
ritchie46
commented
Nov 16, 2023
| @@ -570,42 +570,19 @@ pub fn cast( | |||
| }, | |||
|
|
|||
| (Utf8, _) => match to_type { | |||
| UInt8 => utf8_to_primitive_dyn::<i32, u8>(array, to_type, options), | |||
There was a problem hiding this comment.
Remove branches we never hit in polars.
ritchie46
commented
Nov 16, 2023
| _ => polars_bail!(InvalidOperation: | ||
| "casting from {from_type:?} to {to_type:?} not supported", | ||
| ), | ||
| }, | ||
| (LargeUtf8, _) => match to_type { | ||
| UInt8 => utf8_to_primitive_dyn::<i64, u8>(array, to_type, options), |
There was a problem hiding this comment.
Reuse the binary code for this.
ritchie46
requested review from
stinodego,
alexander-beedie and
MarcoGorelli
as code owners
ritchie46
changed the title
stinodego
added
the
build
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still have some lexical in arrow cast. Will get that out later.closes #12463