Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(python,rust!): Add dedicated horizontal aggregation methods to DataFrame #12492

Merged
merged 7 commits into from
Nov 17, 2023
Merged

feat(python,rust!): Add dedicated horizontal aggregation methods to DataFrame #12492

merged 7 commits into from
Nov 17, 2023

Conversation

stinodego
Copy link
Contributor

@stinodego stinodego commented Nov 15, 2023 •
edited
Loading

Closes #12484

Changes

  • Add the following DataFrame methods:
    • sum_horizontal
    • mean_horizontal
    • max_horizontal
    • min_horizontal
  • On the Rust side, rename hsum/hmean/hmax/hmin to the names above.
  • On the Python side, deprecate the horizontal component of the overloaded sum/mean/max/min methods.

There is more cleanup to be done around these methods (e.g. add LazyFrame methods, proper dispatching), but at least this takes care of the deprecation and public API.

@github-actions github-actions bot added breaking rust Change that breaks backwards compatibility for the Rust crate enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Nov 15, 2023
@stinodego stinodego added the deprecation Add a deprecation warning to outdated functionality label Nov 15, 2023
@stinodego stinodego added this to the 1.0.0 milestone Nov 15, 2023
@stinodego stinodego marked this pull request as ready for review November 15, 2023 21:12
@stinodego stinodego modified the milestones: 1.0.0, 0.19.14 Nov 16, 2023
@ritchie46 ritchie46 merged commit 655391c into main Nov 17, 2023
25 checks passed
@ritchie46 ritchie46 deleted the df-horizontal branch November 17, 2023 08:20
@romanovacca romanovacca mentioned this pull request Dec 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-banach s-banach s-banach left review comments

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
breaking rust Change that breaks backwards compatibility for the Rust crate deprecation Add a deprecation warning to outdated functionality enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
0.19.14
Development

Successfully merging this pull request may close these issues.

Add dedicated horizontal aggregation methods to dataframe
3 participants
@stinodego @s-banach @ritchie46