Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(rust): Add test for CSV parsing of quoted fields with line breaks #12487

Closed
wants to merge 1 commit into from
Closed

test(rust): Add test for CSV parsing of quoted fields with line breaks #12487

wants to merge 1 commit into from

Conversation

demetribu
Copy link
Contributor

Add test for CSV parsing of quoted fields with line breaks

  • Implements a new test case test_quoted_fields_with_line_breaks in the CSV module.
  • This test verifies that Polars correctly handles quoted fields containing line breaks within CSV files.
  • Ensures that multiline strings within quotes are read as a single field without errors.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Nov 15, 2023
@ritchie46
Copy link
Member

Is there any reason you write this test? I am fairly positive we already test this.

@demetribu demetribu closed this Nov 15, 2023
@demetribu demetribu deleted the test_quoted_fields_with_line_breaks branch November 15, 2023 17:59
@alexander-beedie
Copy link
Collaborator

alexander-beedie commented Nov 15, 2023

Yup; test_skip_new_line_embedded_lines covers newlines in CSV string values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants