fix: dont overflow when calculating date range over very long periods #12479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
MarcoGorelli
force-pushed
the
long-date-range
branch
from
42a6710 to
c9361a4
Compare
MarcoGorelli
requested review from
ritchie46,
stinodego,
alexander-beedie and
orlp
as code owners
MarcoGorelli
commented
Nov 15, 2023
Comment on lines
-692
to
+694
| let t_weeks = nsecs_to_unit(self.weeks * NS_WEEK); | ||
| let t_weeks = nsecs_to_unit(NS_WEEK) * self.weeks; |
There was a problem hiding this comment.
this could be cleaner with, say, MS_WEEK and US_WEEK...but this simple change at least fixes the issue
ritchie46
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12461