Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(python): set dtype of numbers bigger than i64 max to float #12476

Closed
wants to merge 2 commits into from
Closed

fix(python): set dtype of numbers bigger than i64 max to float #12476

wants to merge 2 commits into from

Conversation

TomHaii
Copy link

@TomHaii TomHaii commented Nov 15, 2023 •
edited
Loading

fixes #12473

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Nov 15, 2023
@TomHaii TomHaii changed the title fix: set dtype of numbers bigger than i64 max to float fix(python): set dtype of numbers bigger than i64 max to float Nov 15, 2023
@ritchie46
Copy link
Member

Thanks for the PR, but I don't think this is the way. See comment/discussion in issue.

@ritchie46 ritchie46 closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@stinodego stinodego Awaiting requested review from stinodego

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infer schema setting dtype to I64 although it exceeded max integer
2 participants
@TomHaii @ritchie46