refactor(rust): rename the DataType in the polars-arrow crate to ArrowDataType for clarity, preventing conflation with our own/native DataType
#12459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
changed the title
DataType in the polars-arrow crate to ArrowDataType for clarity, preventing conflation with our own/native polars DataTypeDataType in the polars-arrow crate to ArrowDataType for clarity, preventing conflation with our own/native polars DataType
github-actions
bot
added
internal
…DataType` for clarity, preventing conflation with our own/native polars `DataType`
alexander-beedie
force-pushed
the
polars-arrow-datatype-name
branch
from
499c783 to
408194c
Compare
alexander-beedie
changed the title
DataType in the polars-arrow crate to ArrowDataType for clarity, preventing conflation with our own/native polars DataTypeDataType in the polars-arrow crate to ArrowDataType for clarity, preventing conflation with our own/native DataType
ritchie46
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"That escalated quickly..." 😅
Having two different flavours of
DataTypewasn't ideal; now that we've brought the code inside (viapolars-arrow) it makes sense to better distinguish between the two - easier to reason about at a glance with respect to function signatures and return types, easier to search for, etc.We already had cases where the two names would collide, handled with:
pub use arrow::datatypes::DataType as ArrowDataType.This PR formalises the distinction using that naming (following a quick sanity-check with @ritchie46).
Note
As you'd hope for something this size it is only a rename/refactor - no functional code/logic changed. The only reason the
+/-on this PR shows positive is because the extra length of "ArrowDataType" vs "DataType" sometimes causes the formatting to break across extra lines, like so: