depr(python): Deprecate DataType method is_not
#12458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
deprecation
stinodego
requested review from
ritchie46,
alexander-beedie and
MarcoGorelli
as code owners
|
It made more sense when we had very few integrated equality checks, as it was explicit/clean - now that we have a whole host of such checks I agree wholeheartedly that we should deprecate it and rely on standard use of "not" for everything. More consistent, no special-casing 👍 |
|
All right, then this is going in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method does not offer anything that
DataType.is_does not already offer us. We don't offeris_not_integer,is_not_nestedetc. either, so I think we're better off without this method. It's not like this is used so commonly that the method is a must-have.@alexander-beedie I think you introduced this one - what are your thoughts on this?