fix(python): ensure explicit "return_dtype" is respected by map_dicts
#12436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
requested review from
ritchie46,
stinodego and
MarcoGorelli
as code owners
ritchie46
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12410, partially addresses #11332.
Significantly streamlined
map_dictsimplementation to avoid a lot of copy/paste and make it a little easier to reason about.Fixed issue where an explicitly-provided "result_dtype" value was not being passed through to the underlying
map_batchesexpression, and added some coverage.Note: only partially addresses #11332 as we should probably be able to do better with inference in the absence of an explicit "result_dtype", such that the
fill_nullsucceeds (it currently fails as the expression dtype is considered "Unknown" and it is looking for numeric columns to fill, ref: #7700).