-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(python,rust): Allow append/zip_with/extend on local categoricals #12369
Conversation
crates/polars-core/src/chunked_array/builder/list/categorical.rs
Outdated
Show resolved
Hide resolved
crates/polars-core/src/chunked_array/builder/list/categorical.rs
Outdated
Show resolved
Hide resolved
crates/polars-core/src/chunked_array/builder/list/categorical.rs
Outdated
Show resolved
Hide resolved
crates/polars-core/src/chunked_array/builder/list/categorical.rs
Outdated
Show resolved
Hide resolved
crates/polars-core/src/chunked_array/builder/list/categorical.rs
Outdated
Show resolved
Hide resolved
crates/polars-core/src/chunked_array/builder/list/categorical.rs
Outdated
Show resolved
Hide resolved
crates/polars-core/src/chunked_array/builder/list/categorical.rs
Outdated
Show resolved
Hide resolved
crates/polars-core/src/chunked_array/logical/categorical/merge.rs
Outdated
Show resolved
Hide resolved
Sorry to bother you! Just wondering whether there's a path from here to joining on local categoricals. |
fn merge_local_rhs_categorical<'a>( | ||
categories: &'a Utf8Array<i64>, | ||
ca_right: &'a CategoricalChunked, | ||
) -> Result<(impl Iterator<Item = Option<u32>> + 'a, Arc<RevMapping>), PolarsError> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that the finish
always takes a materialized CategoricalChunked
.
I think for now we must then update this return type. That means we don't have to return a "flattened" iterator, but can materialize via apply_generic
which will ensure we traverse in the most optimal way.
But let's first get the bugs fixed and improve in a follow up PR.
In the interim, pyarrow will join tables by categorical
|
Yes, in the future it would be possible to join on local categoricals with this merge operation. |
fix #12091
fix #10393