feat(python): Add DataType.is_integer and other dtype groups
#12200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
stinodego
requested review from
ritchie46,
alexander-beedie and
MarcoGorelli
as code owners
stinodego
changed the title
DataType.is_integer/float/temporalDataType.is_integer and other dtype groups
stinodego
force-pushed
the
is-dtype-methods
branch
from
e273476 to
d70ea5d
Compare
stinodego
added
the
deprecation
|
Gets my vote (consolidating these methods on |
stinodego
force-pushed
the
is-dtype-methods
branch
from
d70ea5d to
988be07
Compare
stinodego
force-pushed
the
is-dtype-methods
branch
from
988be07 to
b08ea35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #12196
This includes the "dtype group" methods on
DataType:is_numericis_integeris_signed_integeris_unsigned_integeris_floatis_temporal(
is_nestedcannot be added right now - I will add it as a breaking change in the next breaking release)This PR also deprecates the similar methods on
Series. Users should call theSeries.dtypeand then call the new methods instead.This illustrates the syntax and implementation. For our internal use, you can see it has the additional benefit of not having to import the dtype groups everywhere.