-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(python,rust): str.concat on empty list #12066
fix(python,rust): str.concat on empty list #12066
Conversation
I personally +1 for this change and it keep the behavior before #11488. I will take a look at the remaining issue of skipping nulls. |
If you work on this you should probably look into here #6919
So I think the goal is to either "ignore" or "raise" if nulls occur (current problem is that they appear as |
I'm a little hesitant to add the |
@reswqa I would greenlight implementation with |
@orlp Ah, make sense. I will draft this recently. |
aggregation methods should always return a single value, otherwise it can lead to unexpected behavior and bugs (e.g. #12053)
current behavior:
PR:
str.concat
should skipnulls
and benull
for empty groups #10814 (comment))Note: this does not address the issue of skipping nulls (#10814) but only fixes the bug for empty lists