fix(rust,python): use actual number of read rows for hive materialization #11690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
nameexhaustion
requested review from
ritchie46,
stinodego,
alexander-beedie and
orlp
as code owners
ritchie46
reviewed
Oct 12, 2023
| @@ -99,9 +99,11 @@ pub(super) fn array_iter_to_series( | |||
| fn materialize_hive_partitions( | |||
| df: &mut DataFrame, | |||
| hive_partition_columns: Option<&[Series]>, | |||
| num_rows: usize, | |||
| num_rows: Option<usize>, | |||
There was a problem hiding this comment.
Where is this Some passed? I only see it called with None.
There was a problem hiding this comment.
Hmm, nowhere actually - will remove the parameter.
There was a note on top of the function We have a special num_rows arg, as df can be empty., but there doesn't seem to be any need to special handling in this case - I added a test that loads .head(0) and it seems to work fine.
ritchie46
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Thank you for the quick fix @nameexhaustion. Much appreciated.
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11682
md.num_rows()cannot be used ascolumn_idx_to_seriesmay not read the entire row group when there is a SELECT->LIMIT