feat(python): add support for "outer" mode to frame update method
#11688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
requested review from
ritchie46 and
stinodego
as code owners
github-actions
bot
added
enhancement
ritchie46
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11684.
We didn't explicitly support
how="outer"here, but did let it through silently. It would mostly work, except in the edge-case described in the linked issue; this PR now explicitly allows for an "outer" mode, explicitly disallows any join strategy that we don't support inupdate, and better validates all of the expected behaviour.Also adds more examples and tests, as the various "how" options (outside of the default "left") were either barely tested or not tested at all (and had no supporting examples).