Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(rust): Cleanup the match block for date inference #11677

Merged
merged 2 commits into from
Oct 12, 2023
Merged

refactor(rust): Cleanup the match block for date inference #11677

merged 2 commits into from
Oct 12, 2023

Conversation

svaningelgem
Copy link
Contributor

While investigating issues, I encountered this block and thought it could be more cleanly written.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Oct 12, 2023
@svaningelgem svaningelgem marked this pull request as ready for review October 12, 2023 07:19
@orlp
Copy link
Collaborator

orlp commented Oct 12, 2023

Thanks! Better indeed.

@orlp orlp merged commit 86aafa8 into pola-rs:main Oct 12, 2023
17 checks passed
@svaningelgem svaningelgem deleted the refactor/huge-match-block branch October 12, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlp orlp orlp approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

Assignees
No one assigned
Labels
internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svaningelgem @orlp