fix(rust, python): Fix match on last item for join_asof with strategy="nearest"
#11673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcrumiller
requested review from
ritchie46,
stinodego and
alexander-beedie
as code owners
github-actions
bot
added
fix
mcrumiller
force-pushed
the
join-asof-last-item
branch
from
c0267bf to
0071910
Compare
mcrumiller
commented
Oct 11, 2023
| @@ -259,10 +258,15 @@ pub(super) fn join_asof_nearest_with_tolerance< | |||
| break; | |||
| } | |||
| } else { | |||
| // We'ved moved farther away, so the last element was the match. | |||
| out.push(Some(offset - 1)); | |||
| // We'ved moved farther away, so the last element was the match if it's within tolerance | |||
There was a problem hiding this comment.
The code previously was simply accepting that the prior match was a success without making sure it was eligible, ditto for the groups version below.
|
@mcrumiller I had assigned that issue to me :( I'm working a refactor for this that also cleans everything up. |
Ahh no problem. I wrote the original code so I felt responsible (I am) for the error. Should I just close this? |
|
I suppose we can merge it to ensure the bug is fixed sooner and it adds tests. I'll deal with the rebase errors. |
orlp
approved these changes
Oct 12, 2023
stinodego
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11649