Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: sum_horizontal to expression architecture #11659

Merged
merged 1 commit into from
Oct 12, 2023
Merged

refactor: sum_horizontal to expression architecture #11659

merged 1 commit into from
Oct 12, 2023

Conversation

reswqa
Copy link
Collaborator

@reswqa reswqa commented Oct 11, 2023

Will handle other *_horizontal dependent on reduce_exprs in the next PR.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Oct 11, 2023
@reswqa reswqa marked this pull request as ready for review October 12, 2023 02:21
@ritchie46 ritchie46 merged commit 4a368f5 into pola-rs:main Oct 12, 2023
24 checks passed
@romanovacca romanovacca mentioned this pull request Oct 19, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@stinodego stinodego Awaiting requested review from stinodego

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reswqa @ritchie46