Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(python): reorder pl.duration arguments #11641

Merged
merged 3 commits into from
Oct 14, 2023
Merged

refactor(python): reorder pl.duration arguments #11641

merged 3 commits into from
Oct 14, 2023

Conversation

Julian-J-S
Copy link
Contributor

reordering pl.duration arguments in descending value/size order like discussed in #11625 (@MarcoGorelli)

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Oct 10, 2023
MarcoGorelli
MarcoGorelli approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@MarcoGorelli MarcoGorelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks @JulianCologne

(leaving open a bit in case others have objections wait I can't merge it anyway outside of polars-time 😄 )

@stinodego
Copy link
Member

Hm, I guess this is fine. But can we then also reorder this internally (e.g. the if-statements in the function, the PyO3 function, ...)?

@stinodego stinodego force-pushed the refactor-duration-arguments branch from 1cfc7b3 to 1ceb537 Compare October 14, 2023 07:54
@stinodego stinodego force-pushed the refactor-duration-arguments branch from 1ceb537 to 49884a9 Compare October 14, 2023 07:56
@stinodego stinodego merged commit 5894b7d into pola-rs:main Oct 14, 2023
13 checks passed
@Julian-J-S Julian-J-S deleted the refactor-duration-arguments branch October 19, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

@stinodego stinodego stinodego approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

Assignees
No one assigned
Labels
internal An internal refactor or improvement python Related to Python Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Julian-J-S @stinodego @MarcoGorelli