refactor(rust): Make all emw function expr non-anonymous #11638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
|
Locally no errors with |
reswqa
reviewed
Oct 10, 2023
reswqa
reviewed
Oct 10, 2023
ritchie46
reviewed
Oct 13, 2023
There was a problem hiding this comment.
Almost there @romanovacca. We can use the already existing mapper functions to get the proper dtype.
| _ => DataType::Float64, | ||
| }), | ||
| #[cfg(feature = "ewma")] | ||
| EwmStd { .. } => mapper.map_dtype(|dt| match dt { |
There was a problem hiding this comment.
We have mapper.map_to_float_dtype
|
@romanovacca can you do a rebase? Then it is good to go. |
romanovacca
requested review from
c-peters,
stinodego,
alexander-beedie and
MarcoGorelli
as code owners
|
Im messing up the rebase, trying to fix it |
romanovacca
force-pushed
the
ewma_to_functionExpr
branch
from
0bcbf3c to
c5f8aad
Compare
|
Alright! Here it goes. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.