Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Make value_counts and unique_counts function expr non-anonymous #11601

Merged
merged 1 commit into from
Oct 9, 2023
Merged

refactor: Make value_counts and unique_counts function expr non-anonymous #11601

merged 1 commit into from
Oct 9, 2023

Conversation

reswqa
Copy link
Collaborator

@reswqa reswqa commented Oct 9, 2023

This closes #11459.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Oct 9, 2023
@reswqa reswqa marked this pull request as ready for review October 9, 2023 04:04
@reswqa reswqa requested review from ritchie46 and orlp as code owners October 9, 2023 04:04
@ritchie46
Copy link
Member

Thank you!

@ritchie46 ritchie46 merged commit 0ae1b6e into pola-rs:main Oct 9, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expressions should have the same plan after CSE? value_counts + unnest vs struct.field
2 participants
@reswqa @ritchie46