Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python,rust,cli): add
DATE
function for SQL #11541feat(python,rust,cli): add
DATE
function for SQL #11541Changes from 4 commits
192b1cd
e03ef33
792ec4c
e08f828
148e362
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe postgres (which we are trying to mimic where possible) calls this to_date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see - thanks.
So should
Date
anddate
be replaced withToDate
andto_date
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh,
TO_DATE
is actually a separate function that requires a second argument (a format string which is not strftime, but rather one of the "YYYY-MM-DD" type ones; we should probably skip this for now until we can map from that flavour of format string to strftime 🤔).In this case
DATE
is appropriate as it valid and only needs the string - can be called like so:(I just quickly checked this on a local PostgreSQL connection ;))