enforce keyword-only

pola-rs · Jun 21, 2024 · 9de041c · 9de041c
1 parent 0219f0b
commit 9de041c
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/py-polars/polars/dataframe/frame.py b/py-polars/polars/dataframe/frame.py
@@ -7589,11 +7589,11 @@ def explode(
     @deprecate_renamed_parameter("columns", "on", version="1.0.0")
     def pivot(
         self,
+        *,
         on: ColumnNameOrSelector | Sequence[ColumnNameOrSelector] | None,
         index: ColumnNameOrSelector | Sequence[ColumnNameOrSelector] | None,
         values: ColumnNameOrSelector | Sequence[ColumnNameOrSelector] | None,
         aggregate_function: PivotAgg | Expr | None = None,
-        *,
         maintain_order: bool = True,
         sort_columns: bool = False,
         separator: str = "_",
@@ -7805,6 +7805,7 @@ def pivot(
 
     def unpivot(
         self,
+        *,
         on: ColumnNameOrSelector | Sequence[ColumnNameOrSelector] | None = None,
         index: ColumnNameOrSelector | Sequence[ColumnNameOrSelector] | None = None,
         variable_name: str | None = None,

diff --git a/py-polars/polars/lazyframe/frame.py b/py-polars/polars/lazyframe/frame.py
@@ -5705,11 +5705,11 @@ def drop_nulls(
 
     def unpivot(
         self,
+        *,
         on: ColumnNameOrSelector | Sequence[ColumnNameOrSelector] | None = None,
         index: ColumnNameOrSelector | Sequence[ColumnNameOrSelector] | None = None,
         variable_name: str | None = None,
         value_name: str | None = None,
-        *,
         streamable: bool = True,
     ) -> Self:
         """

diff --git a/py-polars/tests/unit/operations/test_filter.py b/py-polars/tests/unit/operations/test_filter.py
@@ -40,7 +40,7 @@ def test_unpivot_values_predicate_pushdown() -> None:
     ).lazy()
 
     assert (
-        lf.unpivot("id", ["asset_key_1", "asset_key_2", "asset_key_3"])
+        lf.unpivot(index="id", on=["asset_key_1", "asset_key_2", "asset_key_3"])
         .filter(pl.col("value") == pl.lit("123"))
         .collect()
     ).to_dict(as_series=False) == {

diff --git a/py-polars/tests/unit/operations/test_unpivot.py b/py-polars/tests/unit/operations/test_unpivot.py
@@ -76,10 +76,10 @@ def test_unpivot_projection_pd_7747() -> None:
 
 
 # https://github.com/pola-rs/polars/issues/10075
-def test_unpivot_no_value_vars() -> None:
+def test_unpivot_no_on() -> None:
     lf = pl.LazyFrame({"a": [1, 2, 3]})
 
-    result = lf.unpivot("a")
+    result = lf.unpivot(index="a")
 
     expected = pl.LazyFrame(
         schema={"a": pl.Int64, "variable": pl.String, "value": pl.Null}