fix: Fix DataFrame.min/max for decimals (#14890)

pola-rs · Mar 6, 2024 · 3cf4897 · 3cf4897
1 parent 4e521e8
commit 3cf4897
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/crates/polars-core/src/datatypes/dtype.rs b/crates/polars-core/src/datatypes/dtype.rs
@@ -258,6 +258,7 @@ impl DataType {
 
         let phys = self.to_physical();
         (phys.is_numeric()
+            || self.is_decimal()
             || matches!(
                 phys,
                 DataType::Binary | DataType::String | DataType::Boolean

diff --git a/py-polars/tests/unit/datatypes/test_decimal.py b/py-polars/tests/unit/datatypes/test_decimal.py
@@ -322,6 +322,14 @@ def test_decimal_df_vertical_sum() -> None:
     assert_frame_equal(df.sum(), expected)
 
 
+def test_decimal_df_vertical_agg() -> None:
+    df = pl.DataFrame({"a": [D("1.0"), D("2.0"), D("3.0")]})
+    expected_min = pl.DataFrame({"a": [D("1.0")]})
+    expected_max = pl.DataFrame({"a": [D("3.0")]})
+    assert_frame_equal(df.min(), expected_min)
+    assert_frame_equal(df.max(), expected_max)
+
+
 def test_decimal_in_filter() -> None:
     df = pl.DataFrame(
         {