Remove needless return skips

pola-rs · Oct 28, 2024 · 3cdadd5 · 3cdadd5
1 parent 137daa2
commit 3cdadd5
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 18 deletions.
diff --git a/crates/polars-arrow/src/io/ipc/read/flight.rs b/crates/polars-arrow/src/io/ipc/read/flight.rs
@@ -414,7 +414,6 @@ mod test {
     }
 
     #[tokio::test]
-    #[allow(clippy::needless_return)]
     async fn test_file_flight_simple() {
         let path = &get_file_path();
         let mut file = tokio::fs::File::open(path).await.unwrap();
@@ -427,7 +426,6 @@ mod test {
     }
 
     #[tokio::test]
-    #[allow(clippy::needless_return)]
     async fn test_file_flight_amortized() {
         let path = &get_file_path();
         let mut file = File::open(path).await.unwrap();

diff --git a/crates/polars/tests/it/io/avro/read_async.rs b/crates/polars/tests/it/io/avro/read_async.rs
@@ -26,25 +26,16 @@ async fn test(codec: Codec) -> PolarsResult<()> {
     Ok(())
 }
 
-// Issue with clippy interacting with tokio. See:
-// https://github.com/rust-lang/rust-clippy/issues/13458
-#[allow(clippy::needless_return)]
 #[tokio::test]
 async fn read_without_codec() -> PolarsResult<()> {
     test(Codec::Null).await
 }
 
-// Issue with clippy interacting with tokio. See:
-// https://github.com/rust-lang/rust-clippy/issues/13458
-#[allow(clippy::needless_return)]
 #[tokio::test]
 async fn read_deflate() -> PolarsResult<()> {
     test(Codec::Deflate).await
 }
 
-// Issue with clippy interacting with tokio. See:
-// https://github.com/rust-lang/rust-clippy/issues/13458
-#[allow(clippy::needless_return)]
 #[tokio::test]
 async fn read_snappy() -> PolarsResult<()> {
     test(Codec::Snappy).await

diff --git a/crates/polars/tests/it/io/avro/write_async.rs b/crates/polars/tests/it/io/avro/write_async.rs
@@ -42,9 +42,6 @@ async fn roundtrip(compression: Option<Compression>) -> PolarsResult<()> {
     Ok(())
 }
 
-// Issue with clippy interacting with tokio. See:
-// https://github.com/rust-lang/rust-clippy/issues/13458
-#[allow(clippy::needless_return)]
 #[tokio::test]
 async fn no_compression() -> PolarsResult<()> {
     roundtrip(None).await

diff --git a/docs/source/src/rust/user-guide/io/cloud-storage.rs b/docs/source/src/rust/user-guide/io/cloud-storage.rs
@@ -1,7 +1,3 @@
-// Issue with clippy interacting with tokio. See:
-// https://github.com/rust-lang/rust-clippy/issues/13458
-#![allow(clippy::needless_return)]
-
 // --8<-- [start:read_parquet]
 use aws_config::BehaviorVersion;
 use polars::prelude::*;