build(rust): Fix some feature flag issues (#19512)

pola-rs · Oct 29, 2024 · 1c1574a · 1c1574a
1 parent f64fe8a
commit 1c1574a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/crates/polars-lazy/Cargo.toml b/crates/polars-lazy/Cargo.toml
@@ -71,7 +71,7 @@ temporal = [
 ]
 # debugging purposes
 fmt = ["polars-core/fmt", "polars-plan/fmt"]
-strings = ["polars-plan/strings", "polars-stream/strings"]
+strings = ["polars-plan/strings", "polars-stream?/strings"]
 future = []
 
 dtype-full = [
@@ -163,7 +163,7 @@ bitwise = [
   "polars-plan/bitwise",
   "polars-expr/bitwise",
   "polars-core/bitwise",
-  "polars-stream/bitwise",
+  "polars-stream?/bitwise",
   "polars-ops/bitwise",
 ]
 approx_unique = ["polars-plan/approx_unique"]
@@ -203,7 +203,7 @@ dynamic_group_by = [
   "temporal",
   "polars-expr/dynamic_group_by",
   "polars-mem-engine/dynamic_group_by",
-  "polars-stream/dynamic_group_by",
+  "polars-stream?/dynamic_group_by",
 ]
 ewma = ["polars-plan/ewma"]
 ewma_by = ["polars-plan/ewma_by"]

diff --git a/crates/polars-plan/src/dsl/string.rs b/crates/polars-plan/src/dsl/string.rs
@@ -593,7 +593,7 @@ impl StringNameSpace {
         )
     }
 
-    #[cfg(feature = "strings")]
+    #[cfg(feature = "regex")]
     pub fn escape_regex(self) -> Expr {
         self.0.map_many_private(
             FunctionExpr::StringExpr(StringFunction::EscapeRegex),

diff --git a/crates/polars-stream/Cargo.toml b/crates/polars-stream/Cargo.toml
@@ -41,3 +41,7 @@ bitwise = ["polars-core/bitwise", "polars-plan/bitwise"]
 merge_sorted = ["polars-plan/merge_sorted"]
 dynamic_group_by = []
 strings = []
+
+# We need to specify default features here to match workspace defaults.
+# Otherwise we get warnings with cargo check/clippy.
+default = ["bitwise"]