-
Notifications
You must be signed in to change notification settings - Fork 49
Various bits of cleanup #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
vyasr
wants to merge
13
commits into
pola-rs:main
Choose a base branch
from
vyasr:chore/cleanup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matt711
reviewed
Apr 16, 2025
Matt711
approved these changes
Apr 18, 2025
Merged
Based on some feedback in the Discord, I'll attempt to split this PR up into more easily reviewable chunks. |
This was referenced Apr 23, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to run the benchmarks in the repo and found various small improvements that should help with being able to run these more out of the box:
python -m
commands from running since that relies on the current directory being on sys.pathrun-polars
, but if we want to change that so that all targets rebuild the tables this change would helpFeel free to let me know if any of these changes seem undesirable for some reason that I am not aware of.
In the process I also improved docs/comments in a couple of places and fixed some formatting. I also deleted a file that looks like it was recently added accidentally in #144.