Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on rstan branch #28

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Remove dependency on rstan branch #28

merged 1 commit into from
Jan 3, 2024

Conversation

nehill197
Copy link
Member

Running into issues with bisonpictools with a V8 namespace warning.
We think that the features that the rstan branch was needed for have been merged into the cran version of rstan.

@nehill197 nehill197 marked this pull request as draft December 14, 2023 18:24
@nehill197
Copy link
Member Author

The checks fail as they did before this pull request, due to 3 failing tests noted in issue #27.

@nehill197 nehill197 marked this pull request as ready for review December 15, 2023 16:54
@nehill197 nehill197 requested a review from joethorley December 15, 2023 16:54
Copy link
Member

@joethorley joethorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks for being on it

@nehill197 nehill197 merged commit 3009581 into main Jan 3, 2024
1 of 7 checks passed
@nehill197 nehill197 deleted the rstanversion branch January 3, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants