Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upkeep #47

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Upkeep #47

wants to merge 5 commits into from

Conversation

dunkenwg
Copy link
Contributor

No description provided.

@dunkenwg
Copy link
Contributor Author

@joethorley, the GitHub actions in this repo are far more advanced than those in embr so I don't want to go and mess anything up before talking to you. The Smoke test: stock R - Matrix: rcc-suggests - Without ggplot2 action is already failing because jmbr.Rmd uses ggplot2 and the vignette can't build without this package. Do you want me to switch ggplot2 from a suggest to an import in the DESCRIPTION or would you rather solve this in some other way?

@joethorley
Copy link
Member

@dunkenwg - good question let's park for now until I have chance to dig into it.

@joethorley joethorley marked this pull request as draft January 29, 2025 23:18
@joethorley
Copy link
Member

I've converted to draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dunkenwg @joethorley