Add support for dynamic log level in Uinta.Plug #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I received a request for 500-level responses to get logged with a level of
:error
, but Uinta does not currently support log levels that change based on the status code (conn-ditions?). Without thinking through the issue in its entirety I would maybe be of the opinion that meta-logs about requests/responses are always informational and for 500-level responses the reason they're 500-level ought to be logged at the appropriate level. The request, however, does not seem unreasonable, andPhoenix.Logger
supports dynamic log level, so I'm proposing it for Uinta.