Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dynamic log level in Uinta.Plug #63

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

brettbeatty
Copy link
Contributor

I received a request for 500-level responses to get logged with a level of :error, but Uinta does not currently support log levels that change based on the status code (conn-ditions?). Without thinking through the issue in its entirety I would maybe be of the opinion that meta-logs about requests/responses are always informational and for 500-level responses the reason they're 500-level ought to be logged at the appropriate level. The request, however, does not seem unreasonable, and Phoenix.Logger supports dynamic log level, so I'm proposing it for Uinta.

@brettbeatty brettbeatty requested a review from a team as a code owner April 16, 2024 19:39
@epinault epinault merged commit bba7fac into master Apr 16, 2024
12 checks passed
@epinault epinault deleted the brett.beatty/dynamic_log_level branch April 16, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants