Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate Limiting Additions #47

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Conversation

hvalkerie19
Copy link
Contributor

Updates to the Rate Limiting Section In ESCT: Part 3 - Secure SDLC Concepts Elixir Sec Coding Training - Improve Rate-Limiting Lesson (issue #24)

Updates to the Rate Limiting Section In ESCT: Part 3 - Secure SDLC Concepts
Elixir Sec Coding Training - Improve Rate-Limiting Lesson (issue podium#24)
@houllette houllette added new content New topics, lessons, or examples non-elixir content Distinguishes content additions that pertain to more general security practices labels Feb 1, 2023
modules/3-ssdlc.livemd Outdated Show resolved Hide resolved
modules/3-ssdlc.livemd Outdated Show resolved Hide resolved
modules/3-ssdlc.livemd Outdated Show resolved Hide resolved
@houllette
Copy link
Collaborator

This is an awesome start to improving the section on rate limiting!

I think there are two (technically three) sections I'd love to see added to this module that would really make it the bees knees:

  1. Two subsections calling out the difference between Application Rate Limiting (naming dropping Elixir libraries specifically like Hammer) and Network Rate Limiting (Web Application Firewalls) - basically a subsection for each approach that briefly explains which scenarios it makes sense to have that respective type of rate limiting over the other.
  2. An accompanying quiz question to this module would be amazing - one idea I had piggybacks off the Application Rate Limiting concept and centers again around the Hammer library; something along the lines of "Using the Hammer library, protect the provided function with these specifications..."

@houllette houllette linked an issue Feb 1, 2023 that may be closed by this pull request
@houllette houllette mentioned this pull request Feb 1, 2023
@houllette houllette marked this pull request as draft February 1, 2023 23:00
@hvalkerie19
Copy link
Contributor Author

This is an awesome start to improving the section on rate limiting!

I think there are two (technically three) sections I'd love to see added to this module that would really make it the bees knees:

  1. Two subsections calling out the difference between Application Rate Limiting (naming dropping Elixir libraries specifically like Hammer) and Network Rate Limiting (Web Application Firewalls) - basically a subsection for each approach that briefly explains which scenarios it makes sense to have that respective type of rate limiting over the other.
  2. An accompanying quiz question to this module would be amazing - one idea I had piggybacks off the Application Rate Limiting concept and centers again around the Hammer library; something along the lines of "Using the Hammer library, protect the provided function with these specifications..."

-Sections added

Updates complete - ready for review
@hvalkerie19 hvalkerie19 marked this pull request as ready for review February 10, 2023 21:28
@hvalkerie19
Copy link
Contributor Author

Updates complete and ready for review

modules/3-ssdlc.livemd Outdated Show resolved Hide resolved
modules/3-ssdlc.livemd Outdated Show resolved Hide resolved
modules/3-ssdlc.livemd Outdated Show resolved Hide resolved
modules/3-ssdlc.livemd Outdated Show resolved Hide resolved
modules/3-ssdlc.livemd Outdated Show resolved Hide resolved
modules/3-ssdlc.livemd Outdated Show resolved Hide resolved
modules/3-ssdlc.livemd Outdated Show resolved Hide resolved
@houllette houllette changed the title Update 3-ssdlc.livemd Rate Limiting Additions Feb 10, 2023
hvalkerie19 and others added 2 commits February 15, 2023 07:12
Co-authored-by: Holden Oullette <[email protected]>
Co-authored-by: Holden Oullette <[email protected]>
hvalkerie19 and others added 5 commits February 15, 2023 07:17
Co-authored-by: Holden Oullette <[email protected]>
Co-authored-by: Holden Oullette <[email protected]>
Co-authored-by: Holden Oullette <[email protected]>
Co-authored-by: Holden Oullette <[email protected]>
Rearranged lines 143-151 and 153-161 per comment
modules/3-ssdlc.livemd Outdated Show resolved Hide resolved
@hvalkerie19
Copy link
Contributor Author

Updates to Rate Limiting Section are complete with comments above addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new content New topics, lessons, or examples non-elixir content Distinguishes content additions that pertain to more general security practices
Development

Successfully merging this pull request may close these issues.

Improve Rate-Limiting Lesson
2 participants