Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unused error in test and fix markdown format error #414

Merged
merged 2 commits into from
Jul 24, 2019
Merged

Fix unused error in test and fix markdown format error #414

merged 2 commits into from
Jul 24, 2019

Conversation

kigawas
Copy link
Contributor

@kigawas kigawas commented Jul 23, 2019

No description provided.

Copy link
Collaborator

@afck afck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches! 👍
Not sure about some of the Markdown format changes: Are these part of a spec; or a specific style guide?

@kigawas
Copy link
Contributor Author

kigawas commented Jul 23, 2019

@afck
Copy link
Collaborator

afck commented Jul 23, 2019

Thanks! There are also Node.js and Ruby versions. I made a note for later to consider adding them to CI: #416

The test failure is due to a security vulnerability found by cargo audit. I'll look into it today…

@afck
Copy link
Collaborator

afck commented Jul 23, 2019

Wait… it actually isn't!

running 1 test
test run_binary_agreement ... FAILED

@afck
Copy link
Collaborator

afck commented Jul 23, 2019

The problem is that your change in sbv_broadcast.rs actually did change behavior: If 2 * self.netinfo.num_faulty() + 1 is equal to self.netinfo.num_faulty() + 1, both branches should be executed, which is why we didn't use an else here.

@kigawas
Copy link
Contributor Author

kigawas commented Jul 23, 2019

Ah, thanks for pointing out. Already fixed.

@afck afck requested a review from andogro July 23, 2019 09:29
@afck
Copy link
Collaborator

afck commented Jul 23, 2019

I'm "fixing" CI in #417; please rebase once that's merged. Sorry for the inconvenience!

@afck
Copy link
Collaborator

afck commented Jul 23, 2019

Merged; you can rebase now.

@afck afck merged commit 7078387 into poanetwork:master Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants