-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to build API and WEB servers along with regular ones #141
Add possibility to build API and WEB servers along with regular ones #141
Conversation
…and API deployment
Update 1: Found bugs.
|
Update 2: As hashicorp/terraform#21096 and hashicorp/terraform#21333 mentions there is a bug in a Terraform 0.12 core which does not allow to destroy infrastructure. As such I propose the following:
|
I have tested the
|
@vbaranov @symanovich-a |
As for now this could not be merged, at least until hashicorp/terraform-provider-aws#8268 is not merged. |
|
Finally, the hashicorp/terraform-provider-aws#8268 was merged. We can merge this PR next week. |
@vbaranov However, I can see that the documentation migrated to docs.blockscout.org. How to resolve merge conflict? |
@ArseniiPetrovich yes, indeed, we migrated documentation to the docs.blockscout.com. It is managed by GitBook and lives here https://github.com/blockscout/docs. In order to solve merging conflicts, I would suggest to remove updates of docs section in this PR and create a separate one to the docs repo. |
Terraform provider version released. Removing "do not merge" label. |
Closes #133
DETAILS
S3
,S3_debug
andS3_config
were merged into single role with different tasks subsets inside.main_infra
,destroy
andattach_existing_rds
were merged into singleinfrastructure
role as they depend on the same subset of tasks.main_software
role were split into three roles -build
,deploy
andssm_vars
to keep each role nice and small.Thoughts
I've decided to keep these three as a separate roles because of their low coupling and independence (tags:build
,deploy
,update_vars
), but if there are any objections I can possibly merge them into singlesoftware
role with different tasks as I made withmain_infra
role;Details
I've used a workaround with creating the Ansible template on top of one of the TF files which is used to call newly created module because of current Terraform limitations, that will be addressed in the near future.API and WEB servers are served by the common loadbalancer. Due to known bug some of the API are still addressed to the WEB instance along with the write API requests.
vpc_zone_identifier
were set along with theavailability_zones
in TF ASG resource leads to plan inconsistency;STATUS
As for now PR is in MVP (minimal viable product) stage, which means it is still not tested well, but all the functionality are in place. Also it is NOT backward compatible with
master
because of major changes in TF and Ansible scripts. I'll work more to see if there are any workaround to make it compatible.TODO