Merge of #1502. Thanks @SteveWinward

pnp · Aug 9, 2024 · 9a189f5 · 9a189f5
1 parent 1ac19ec
commit 9a189f5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/src/sdk/CHANGELOG.md b/src/sdk/CHANGELOG.md
@@ -13,6 +13,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 ### Changed
 
 - Added ExpirationDataTime to OrganizationLinkOptions #1494 [reshmee011 - Reshmee Auckloo]
+- Update CloudManager.cs for GCC Login URL Fix #1502 [SteveWinward - Steve Winward]
 
 ## [1.13]
 

diff --git a/src/sdk/PnP.Core.Test/Misc/CloudManagerTests.cs b/src/sdk/PnP.Core.Test/Misc/CloudManagerTests.cs
@@ -46,7 +46,7 @@ public void Microsoft365EnvironmentToGraph(string graph, Microsoft365Environment
         [TestMethod()]
         [DataRow("login.microsoftonline.com", Microsoft365Environment.Production)]
         [DataRow("login.windows-ppe.net", Microsoft365Environment.PreProduction)]
-        [DataRow("login.microsoftonline.us", Microsoft365Environment.USGovernment)]
+        [DataRow("login.microsoftonline.com", Microsoft365Environment.USGovernment)]
         [DataRow("login.microsoftonline.de", Microsoft365Environment.Germany)]
         [DataRow("login.chinacloudapi.cn", Microsoft365Environment.China)]
         [DataRow("login.microsoftonline.us", Microsoft365Environment.USGovernmentHigh)]

diff --git a/src/sdk/PnP.Core/Services/Core/CloudManager.cs b/src/sdk/PnP.Core/Services/Core/CloudManager.cs
@@ -19,7 +19,8 @@ internal static Microsoft365Environment GetEnvironmentFromUri(Uri url)
         }
 
         /// <summary>
-        /// Returns the graph authority for the in use environment. See https://docs.microsoft.com/en-us/graph/deployments for details
+        /// Returns the graph authority for the in use environment. See https://docs.microsoft.com/en-us/graph/deployments 
+        /// and https://learn.microsoft.com/en-us/microsoft-365/enterprise/urls-and-ip-address-ranges?view=o365-worldwide for details
         /// </summary>
         /// <param name="environment"></param>
         /// <returns></returns>
@@ -39,7 +40,8 @@ internal static string GetMicrosoftGraphAuthority(Microsoft365Environment enviro
         }
 
         /// <summary>
-        /// Returns the Azure AD login authority. See https://docs.microsoft.com/en-us/graph/deployments for details
+        /// Returns the Azure AD login authority. See https://docs.microsoft.com/en-us/graph/deployments 
+        /// and https://learn.microsoft.com/en-us/microsoft-365/enterprise/urls-and-ip-address-ranges?view=o365-worldwide for details
         /// </summary>
         /// <param name="environment"></param>
         /// <returns></returns>