Fixes XML character escaping in 'spo listitem batch set' command. #6454
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @Saurabh7019! |
milanholemans
requested changes
Nov 16, 2024
There was a problem hiding this comment.
Great fix @Saurabh7019. Since this is a bug, we require our contributors to add an additional test so this cannot happen again in the future. Could you add a test where we validate special characters in a request?
Thanks!
Saurabh7019
force-pushed
the
issue-6430
branch
from
437fb08
to
db01115
Compare
|
Hi @milanholemans, I modified an existing test to simulate input with special characters and verified escaped output. Please let me know if this works or if an additional test is required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6430