Removes Cli.getInstance() #5707
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge conflict alert @waldekmastykarz, probably due to your other PR on validating short options. Could you solve them? |
Will do! |
|
Hi @waldekmastykarz, if you fix the merge conflicts, I'll be able to merge soon. |
waldekmastykarz
force-pushed
the
remove-cli-instance
branch
from
928f73d to
6be3ddf
Compare
martinlingstuyl
approved these changes
Dec 9, 2023
|
Merged manually, thank you 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
Cli.getInstance()and replaces it with a module setup.getInstance()was odd for our needs and seems like a pattern we brought over from c#-like thinking.Most of the refactoring happens in
Cli.tswhich has been renamed to lowercasecli.tsto indicate that it's not exporting a type anymore. One of the things that you might find odd is that insidecli.ts, we're referring to exported properties and functions withcli.propinstead ofprop. This is necessary to allow mocking exported properties in tests.