-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added New Hypergraph Matching Algorithms #157
base: master
Are you sure you want to change the base?
Conversation
Merge in HYP/hypernetx from bugfix/add-edge to develop * commit '857130acb010befd6b47e432a8225a7f98219672': Fix bugs in _add_item; add tests for add_edge
# Conflicts: # hypernetx/__init__.py
# Conflicts: # hypernetx/__init__.py
hey we just added a Python tutorial in tutorials/advanced/ |
Hi @rotshira! Thank you for your contribution! It is very thorough and impressive. We are excited to get it implemented into HNX as a module. It seems that you have all the necessary files for us to put in a new module. The exact process (contribution guidelines) for the needed files and changes for us to review in a PR is documented here https://hypernetx.readthedocs.io/en/develop/contributions.html. If you could go over those contribution guidelines and resubmit the PR with just the needed files it would be appreciated. Specifically, we are looking for just the module (.py) file itself, a tutorial as a notebook, and a unit test file. If you would also like to provide an rst file for the documentation that would be great! specifically something like what was done for Modularity and Clustering (https://hypernetx.readthedocs.io/en/develop/modularity.html). Thank you again! |
hypernetx/algorithms/cc.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move the fast algorithm into matching_algorithms.py and remove this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should not appear as changed. Copy&paste the original version; make sure all spaces are the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have implemented the requested changes and completed the following additions and updates, We have updated the init.py file in hypernetx/algorithms/ to include imports for the new functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add the Matching Algorithm API
@myersau3 are there any other required changes? |
@erelsgl @nivmoti @rotshira I've created a branch called "hypergraph_matching" that I will be using to submit a PR for this module. I had to make a few minor changes to be compatible with our current format but overall everything looks good and runs! Thank you for all the work. I'll make sure that you all are credited with the contributions and will keep you updated! Thank you again! |
@myersau3 If this issue is resolved, please close it. thanks |
This pull request introduces several enhancements and new features to the HyperNetX library:
New Matching Algorithms:
Iterated Sampling Algorithm:
HEDCS-Based Approximation Algorithm:
Greedy Matching Algorithm:
Logging and Debugging:
Experiments and Performance Comparison:
Testing:
Documentation:
Instructions for Reviewers:
Thank you for considering this contribution to the HyperNetX library.