Use c shape files #1151
Open
Use c shape files #1151
+24
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this PR adds over 2 minutes to the total build time, so I'd really prefer keeping this an option still |
|
or I guess it's less bad if ccache works |
|
Let's only merge this once ccache support is fixed then |
|
@z64a will this work with star rod? I'm thinking we just bring it to dx until ccache is fixed in pmret |
I can make it work. Let me get that merged into Star Rod first though. |
bates64
commented
Sep 8, 2024
| @@ -49,15 +52,13 @@ def unpack_color(data): | |||
| return palette | |||
|
|
|||
|
|
|||
| def add_file_ext(name: str, linker: bool = False) -> str: | |||
| def add_file_ext(name: str) -> str: | |||
| if name.startswith("party_"): | |||
| return "party/" + name + ".png" | |||
| elif name.endswith("_hit"): | |||
| return "geom/" + name + ".bin" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fully integrates @HailSanta's shape to C file script in configure.
Removes the
--c-mapsconfigure flag.Backwards compatible.